From 2234f1ce275316ef593b8c4c7f18710a13155f41 Mon Sep 17 00:00:00 2001
From: takahirom <takam.dev@gmail.com>
Date: Fri, 11 Oct 2024 22:51:45 +0900
Subject: [PATCH] Make diff percent nullable

---
 .../github/takahirom/roborazzi/processOutputImageAndReport.kt | 4 +---
 .../kotlin/com/github/takahirom/roborazzi/CaptureResult.kt    | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/include-build/roborazzi-core/src/commonJvmMain/kotlin/com/github/takahirom/roborazzi/processOutputImageAndReport.kt b/include-build/roborazzi-core/src/commonJvmMain/kotlin/com/github/takahirom/roborazzi/processOutputImageAndReport.kt
index f2a089d4..b2b09ae9 100644
--- a/include-build/roborazzi-core/src/commonJvmMain/kotlin/com/github/takahirom/roborazzi/processOutputImageAndReport.kt
+++ b/include-build/roborazzi-core/src/commonJvmMain/kotlin/com/github/takahirom/roborazzi/processOutputImageAndReport.kt
@@ -2,7 +2,6 @@ package com.github.takahirom.roborazzi
 
 import com.dropbox.differ.ImageComparator
 import java.io.File
-import kotlin.properties.Delegates
 
 fun interface EmptyCanvasFactory {
   operator fun invoke(
@@ -87,7 +86,7 @@ fun processOutputImageAndReport(
     }
 
     // Only used by CaptureResult.Changed
-    var diffPercentage by Delegates.notNull<Float>()
+    var diffPercentage: Float? = null
 
     val changed = if (height == goldenRoboCanvas.height && width == goldenRoboCanvas.width) {
       val comparisonResult: ImageComparator.ComparisonResult =
@@ -101,7 +100,6 @@ fun processOutputImageAndReport(
       reportLog("${goldenFile.name} The differ result :$comparisonResult changed:$changed")
       changed
     } else {
-      diffPercentage = Float.NaN // diff. percentage is not defined if new canvas and golden canvas dimensions differ
       reportLog("${goldenFile.name} The image size is changed. actual = (${goldenRoboCanvas.width}, ${goldenRoboCanvas.height}), golden = (${newRoboCanvas.croppedWidth}, ${newRoboCanvas.croppedHeight})")
       true
     }
diff --git a/include-build/roborazzi-core/src/commonMain/kotlin/com/github/takahirom/roborazzi/CaptureResult.kt b/include-build/roborazzi-core/src/commonMain/kotlin/com/github/takahirom/roborazzi/CaptureResult.kt
index 938f273e..b3459a44 100644
--- a/include-build/roborazzi-core/src/commonMain/kotlin/com/github/takahirom/roborazzi/CaptureResult.kt
+++ b/include-build/roborazzi-core/src/commonMain/kotlin/com/github/takahirom/roborazzi/CaptureResult.kt
@@ -75,7 +75,7 @@ sealed interface CaptureResult {
     @SerialName("timestamp")
     override val timestampNs: Long,
     @SerialName("diff_percentage")
-    val diffPercentage: Float,
+    val diffPercentage: Float?,
     @SerialName("context_data")
     override val contextData: Map<String,@Contextual Any>
   ) : CaptureResult {