Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compose] Options set via RoborazziRule are ignored #186

Closed
kirill-kamakin opened this issue Oct 19, 2023 · 1 comment · Fixed by #187
Closed

[Compose] Options set via RoborazziRule are ignored #186

kirill-kamakin opened this issue Oct 19, 2023 · 1 comment · Fixed by #187

Comments

@kirill-kamakin
Copy link

captureRoboImage function for Compose found here does not use RoborazziContext like View functions do here. Due to that, the change threshold set via rule is ignored by Compose tests.
@takahirom
Copy link
Owner

Thank you for reporting this!

@takahirom takahirom mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed a bug where options set via RoborazziRule were ignored takahirom/roborazzi
2 participants
@takahirom @kirill-kamakin