feat: add RBAC to talosctl version output

Refs #3852. Signed-off-by: Alexey Palazhchenko <[email protected]> (cherry picked from commit bbf1c09)
siderolabs · Jun 28, 2021 · 74111d7 · 74111d7
1 parent 728ad5c
commit 74111d7
Show file tree

Hide file tree

Showing 7 changed files with 1,550 additions and 1,428 deletions.
diff --git a/api/machine/machine.proto b/api/machine/machine.proto
@@ -401,6 +401,8 @@ message Version {
   common.Metadata metadata = 1;
   VersionInfo version = 2;
   PlatformInfo platform = 3;
+  // Features describe individual Talos features that can be switched on or off.
+  FeaturesInfo features = 4;
 }
 
 message VersionResponse { repeated Version messages = 1; }
@@ -419,6 +421,12 @@ message PlatformInfo {
   string mode = 2;
 }
 
+// FeaturesInfo describes individual Talos features that can be switched on or off.
+message FeaturesInfo {
+  // RBAC is true if role-based access control is enabled.
+  bool rbac = 1;
+}
+
 // rpc logs
 // The request message containing the process name.
 message LogsRequest {

diff --git a/cmd/talosctl/cmd/talos/version.go b/cmd/talosctl/cmd/talos/version.go
@@ -7,6 +7,7 @@ package talos
 import (
 	"context"
 	"fmt"
+	"strings"
 
 	"github.com/spf13/cobra"
 	"google.golang.org/grpc"
@@ -66,6 +67,13 @@ var versionCmd = &cobra.Command{
 				fmt.Printf("\t%s:        %s\n", "NODE", node)
 
 				version.PrintLongVersionFromExisting(msg.Version)
+
+				var enabledFeatures []string
+				if msg.Features.GetRbac() {
+					enabledFeatures = append(enabledFeatures, "RBAC")
+				}
+
+				fmt.Printf("\tEnabled:     %s\n", strings.Join(enabledFeatures, ", "))
 			}
 
 			return nil

diff --git a/internal/app/machined/internal/server/v1alpha1/v1alpha1_server.go b/internal/app/machined/internal/server/v1alpha1/v1alpha1_server.go
@@ -1058,11 +1058,16 @@ func (s *Server) Version(ctx context.Context, in *empty.Empty) (reply *machine.V
 		}
 	}
 
+	features := &machine.FeaturesInfo{
+		Rbac: s.Controller.Runtime().Config().Machine().Features().RBACEnabled(),
+	}
+
 	return &machine.VersionResponse{
 		Messages: []*machine.Version{
 			{
 				Version:  version.NewVersion(),
 				Platform: platform,
+				Features: features,
 			},
 		},
 	}, nil

diff --git a/internal/integration/cli/config.go b/internal/integration/cli/config.go
@@ -65,6 +65,13 @@ func (suite *TalosconfigSuite) TestMerge() {
 
 // TestNew checks `talosctl config new`.
 func (suite *TalosconfigSuite) TestNew() {
+	stdout := suite.RunCLI([]string{"version"})
+
+	// TODO: fix test (https://github.com/talos-systems/talos/issues/3852)
+	if !strings.Contains(stdout, "Enabled:     RBAC") {
+		suite.T().Skip("skipping this test for now")
+	}
+
 	tempDir := suite.T().TempDir()
 
 	node := suite.RandomDiscoveredNode(machine.TypeControlPlane)