-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add kws for quiet printing throughout the library #133
Comments
Having a quiet option is a terrific idea! Please do implement the code, if you are comfortable doing so. Before doing the pull request, please be sure that all the files that you edited pass pylint on the lines that you edited and run all the tests using:
Thank you for your interest in GOATOOLS, for taking the time to write us, and for tackling the task of adding this code. |
I have submitted some changes to address this issue (not in the enrichment area yet). These changes are preliminary with more to follow. I don't currently have time to modify the code in all places at once, but will attack it piece by piece as it comes up with current tests and functionality. Thank you so much for the great idea. If you have any further feedback, please feel free to leave specific details. |
Just wanted to support this issue: I'm using In the meantime I switched to the forked version of @SirSharpest and after adding an additional commit to enable |
Thank you so much for your interest in GOATOOLS and taking the time to write us to vote for expanding quiet mode to the By default, we are verbose to prevent missing anything, but we wholeheartedly support quiet modes to be run upon user request. I have added quiet mode to the
rather than:
See the Jupyter notebook for the full example. But for more context:
Since the @tanghaibao, can you release a new version of GOATOOLS once the regression tests have passed? Many people have been asking for this, so it would be helpful to release it ASAP. |
Updated to |
@dvklopfenstein |
Hi,
Minor issue, if encorperating goatools into other pipelines it can get quite messy with the large volumes of printing. I propose a key-word argument to disable them.
For example insertion of one line (and 1 indent) would be sufficient at each command which outputs: forked example of 1 particularly verbose output
if this is something which would be considered I can properly implement and make a pull request.
The text was updated successfully, but these errors were encountered: