Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(slack): add more user fields from slack api #124

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

Empyreus
Copy link
Contributor

@Empyreus Empyreus commented Feb 7, 2020

❤ THANKS FOR HELPING OUT :D

Proposed change

Added more user fields for usage in bot from Slack API

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented Feb 7, 2020

Pull Request Test Coverage Report for Build 272

  • 0 of 38 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 37.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
remote/slack/helper.go 0 38 0.0%
Files with Coverage Reduction New Missed Lines %
remote/slack/helper.go 1 0%
Totals Coverage Status
Change from base Build 268: -0.5%
Covered Lines: 820
Relevant Lines: 2161

💛 - Coveralls

@wass3r wass3r changed the title Add User Fields from Slack API enhancement(slack): add more user fields from slack api Feb 9, 2020
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was able to test. looks good - thank you. before merging, could you please run go fmt remote/slack/helper.go (there will be some changes coming to the build pipeline where we make sure this was run to ensure consistent formatting)

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3r wass3r merged commit 40291b4 into target:master Feb 11, 2020
@wass3r wass3r added slack slack remote specific enhancement New feature or request labels Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request slack slack remote specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants