enhance(slack)!: fix workspace token; switch to signing secret #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤ THANKS FOR HELPING OUT :D
Proposed change
Previously we used a separate token (OAuth Acccess Token via
slack_workspace_token
) because it gave access to the usergroups in your workspace. With the permissions changes that Slack made not so long ago, you can now request ausergroup:read
permission for your regular token. This PR drops theslack_workspace_token
requirement if you want to leverage the usergroup functionality.BREAKING CHANGE:
This PR will change the
slack_verification_token
and replace it with the recommended Signing Secret via the newslack_signing_secret
property. If you have the Events API version of the bot deployed you will need to make this change if you are using a version of the bot with this change implemented.Types of changes
What types of changes is this pull request introducing to flottbot? Put an
x
in the boxes that applyChecklist
You can fill this out after creating your PR. Put an
x
in the boxes that apply