Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: various logging and docs fixes #183

Merged
merged 3 commits into from
Jul 20, 2021
Merged

enhance: various logging and docs fixes #183

merged 3 commits into from
Jul 20, 2021

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Jul 20, 2021

❤ THANKS FOR HELPING OUT :D

Proposed change

Adds some consistency to the logging. Also, should be able to run mostly with debug: false and get a decent amount of logs.

Also uses non-JSON logging when cli: true is set since it's expected to be used in terminal.

🚨 WARNING: with debug: true it's possible for some sensitive info to show in logs. i've seen the verification token show up (though that's been deprecated and replaced with the signing secret).

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (change that improves something)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1047713377

  • 65 of 222 (29.28%) changed or added relevant lines in 18 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 35.387%

Changes Missing Coverage Covered Lines Changed/Added Lines %
remote/cli/remote.go 0 1 0.0%
utils/path.go 0 1 0.0%
handlers/script.go 5 7 71.43%
core/prommetric.go 0 3 0.0%
remote/telegram/remote.go 0 3 0.0%
utils/access_check.go 9 12 75.0%
core/configure.go 27 31 87.1%
core/outputs.go 0 4 0.0%
core/remotes.go 0 4 0.0%
core/matcher.go 17 22 77.27%
Files with Coverage Reduction New Missed Lines %
remote/discord/helper.go 1 0%
remote/slack/helper.go 3 0%
Totals Coverage Status
Change from base Build 1045026267: 0.3%
Covered Lines: 850
Relevant Lines: 2402

💛 - Coveralls

@wass3r wass3r merged commit 3b7a296 into master Jul 20, 2021
@wass3r wass3r deleted the enhance/logging branch July 20, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants