From 6d8d3ce3cc27bb45c9399e551d6b3cecb6aae4cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 31 Jul 2023 11:51:27 +0200 Subject: [PATCH] deps: avoid compilation error with ASan Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221 --- common.gypi | 2 +- deps/v8/src/objects/object-macros.h | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/common.gypi b/common.gypi index 100ba00a8fab42..12421a556f1b71 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.3', + 'v8_embedder_string': '-node.4', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/objects/object-macros.h b/deps/v8/src/objects/object-macros.h index f7a7e8081d44c4..635c2449643e5b 100644 --- a/deps/v8/src/objects/object-macros.h +++ b/deps/v8/src/objects/object-macros.h @@ -507,24 +507,24 @@ #ifdef V8_DISABLE_WRITE_BARRIERS #define WRITE_BARRIER(object, offset, value) #else -#define WRITE_BARRIER(object, offset, value) \ - do { \ - DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ - static_assert(kTaggedCanConvertToRawObjects); \ - CombinedWriteBarrier(object, Tagged(object)->RawField(offset), value, \ - UPDATE_WRITE_BARRIER); \ +#define WRITE_BARRIER(object, offset, value) \ + do { \ + DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ + static_assert(kTaggedCanConvertToRawObjects); \ + CombinedWriteBarrier(object, (object)->RawField(offset), value, \ + UPDATE_WRITE_BARRIER); \ } while (false) #endif #ifdef V8_DISABLE_WRITE_BARRIERS #define WEAK_WRITE_BARRIER(object, offset, value) #else -#define WEAK_WRITE_BARRIER(object, offset, value) \ - do { \ - DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ - static_assert(kTaggedCanConvertToRawObjects); \ - CombinedWriteBarrier(object, Tagged(object)->RawMaybeWeakField(offset), \ - value, UPDATE_WRITE_BARRIER); \ +#define WEAK_WRITE_BARRIER(object, offset, value) \ + do { \ + DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ + static_assert(kTaggedCanConvertToRawObjects); \ + CombinedWriteBarrier(object, (object)->RawMaybeWeakField(offset), value, \ + UPDATE_WRITE_BARRIER); \ } while (false) #endif