-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding the overlays when overlay is not added #273
Comments
I think it would be best not to temper with the user opam configuration. This is the reason why we didn't do this in the first place. Using the repo list based solver instead for this would likely be better! |
I think if we make it opt-in it could be fine, but you're right - using repos explicitly instead of dealing with the opam configuration is better in many ways. |
One of the reason I'm suggesting this is because I think it requires about the same amount of work. Setting the repo in the config via the opam libraries is likely a bit involved and requires write access to the opam state so opens up for serious issues. If we realize it's a lot of work to do this using the new solver, I'm happy to have a temporary workaround using the opam switch config! |
Adding the overlay repository in a stateless fashion (without modifying the opam switch) would be very useful for mirage! Currently what we do is that the Makefile |
Related to #315, we can implement this easily in the @TheLortex note that if Mirage was using the |
Currently we only display a warning to let the user know that the overlays are not included and it might lead to packages not installable because of missing dune ports. @samoht suggested that we make
opam-monorepo
add the overlay opam repo. It sounds like a reasonable idea (provided we ask the user for permission first), the opam libraries might allow doing this directly.The text was updated successfully, but these errors were encountered: