Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow containing jobs with same jobId #1163

Open
mghafiri opened this issue Mar 29, 2022 · 2 comments
Open

Flow containing jobs with same jobId #1163

mghafiri opened this issue Mar 29, 2022 · 2 comments

Comments

@mghafiri
Copy link

mghafiri commented Mar 29, 2022

Hello,
I have a case in which I don't need to re-process the job, so I assign same jobId as mentioned in the Throttling section,
It works perfectly in the case of jobs.
BUT when using same mechanism with Flows, it does not notify all the parent queues.

Flow executed (CHILD_QUEUE, containes the TECH0 Job that doesn't notify all its parents)

{
    "queueName": "GRAND_PARENT_QUEUE",
    "name": "GRAND_PARENT 1",
    "opts": {
        "jobId": "GRAND_PARENT1"
    },
    "children": [
        {
            "queueName": "PARENT_QUEUE",
            "name": "ECO01",
            "opts": {
                "jobId": "ECO01"
            },
            "children": [
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH0",
                    "opts": {
                        "jobId": "TECH0"
                    }
                },
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH1",
                    "opts": {
                        "jobId": "TECH1"
                    }
                }
            ]
        },
        {
            "queueName": "PARENT_QUEUE",
            "name": "ECO02",
            "opts": {
                "jobId": "ECO02"
            },
            "children": [
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH0",
                    "opts": {
                        "jobId": "TECH0"
                    }
                },
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH2",
                    "opts": {
                        "jobId": "TECH2"
                    }
                }
            ]
        },
        {
            "queueName": "PARENT_QUEUE",
            "name": "ECO03",
            "opts": {
                "jobId": "ECO03"
            },
            "children": [
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH0",
                    "opts": {
                        "jobId": "TECH0"
                    }
                },
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH3",
                    "opts": {
                        "jobId": "TECH3"
                    }
                }
            ]
        },
        {
            "queueName": "PARENT_QUEUE",
            "name": "ECO04",
            "opts": {
                "jobId": "ECO04"
            },
            "children": [
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "Tech WithoutPV",
                    "opts": {
                        "jobId": "TECH0"
                    }
                },
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH4",
                    "opts": {
                        "jobId": "TECH4"
                    }
                }
            ]
        },
        {
            "queueName": "PARENT_QUEUE",
            "name": "ECO05",
            "opts": {
                "jobId": "ECO05"
            },
            "children": [
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH0",
                    "opts": {
                        "jobId": "TECH0"
                    }
                },
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH5",
                    "opts": {
                        "jobId": "TECH5"
                    }
                }
            ]
        },
        {
            "queueName": "PARENT_QUEUE",
            "name": "ECO06",
            "opts": {
                "jobId": "ECO06"
            },
            "children": [
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH0",
                    "opts": {
                        "jobId": "TECH0"
                    }
                },
                {
                    "queueName": "CHILD_QUEUE",
                    "name": "TECH6",
                    "opts": {
                        "jobId": "TECH6"
                    }
                }
            ]
        }
    ]
}

Thanks in advance

@roggervalf
Copy link
Collaborator

hi @mghafiri, so basically jobs only can have1 parent as mentioned in #1021

@mghafiri
Copy link
Author

Thank you @roggervalf
Wouldn't be better to have this feature for efficiency?
is there any plan to include this feature in uncoming version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants