Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for maintainers 📞 #1842

Open
addyosmani opened this issue Dec 26, 2017 · 16 comments
Open

Call for maintainers 📞 #1842

addyosmani opened this issue Dec 26, 2017 · 16 comments

Comments

@addyosmani
Copy link
Member

tl;dr: interested in helping maintain TodoMVC? Comment here and let's chat.

When @tastejs/todomvc first started, we were fortunate enough to have a new "lead" maintainer more or less each year. In the last few years, with the core team shifting their focus to other projects, we've had less time to review PRs, chat about project direction and approve or reject new app suggestions.

This hasn't stopped the community from continuing to build TodoMVC implementations. Today alone I've seen new apps using WASM, VueJS, Rust, Elm. The list goes on and it would be great for the project to stay up to date with implems being submitted and link out to those that aren't where they can provide value to those wanting to learn.

There's also work to be done coalescing more up to date TodoMVC implementations that happen to be hosted elsewhere. For example, I and @mathiasbynens help maintain the Speedometer benchmark where we've recently updated most TodoMVC apps here to their latest versions, but host them in the benchmark repo (WebKit trunk) with some minor differences (e.g persistence is disabled).

If folks are interested in getting involved in the project, we would ❤️ some help with the following:

  • Code reviewing PRs
  • Closing PRs that are duplicates of newer/older better ones
  • Reviewing issues (e.g are there bugs that impact all apps?)
  • Helping with project direction
  • Helping with project advocacy (e.g helping maintain the project Twitter account)

If you've got time to help out, comment and let us know what you'd like to help with. Sure we can help answer any questions and assist with on-boarding.

@howardroark
Copy link

I'd be glad to help sort/close PRs :)

@FadySamirSadek
Copy link
Collaborator

FadySamirSadek commented Dec 30, 2017

I would be more than happy to help with code reviewing PRs , reviewing issues and closing PRs that are duplicates . I can also help categorizing issues to help new contributors make their first PR .

@bernard-lin
Copy link

Happy to help with maintenance here too!

@nithindavid
Copy link
Contributor

Hey, I could help with

  1. Code reviewing PRs
  2. Closing PRs that are duplicates of newer/older better ones

😄

@addyosmani
Copy link
Member Author

Hey folks. Thanks @bernard-lin @nithindavid @FadySamirSadek @howardroark for your interest. We really appreciate it.

Let's try to get the project back on track! There are currently 142 other issues open and 61 open pull requests. Working on the project tends to involve reviewing three types of changes:

  1. Fixes to existing implementations
  2. Fixes to continuous integration / tests
  3. PRs to add in new implementations

It would help a lot if we had some folks focused on looking at 1) and 2) and others looking at 3).

We're usually conservative about bringing in new implementations just because there's a maintenance cost that builds up over time 🙃 So a "React TodoMVC" or "React + Redux TodoMVC" was fine, but newer libraries/frameworks that have very low traction tend to be entries we'll link to from our wiki until they've got enough momentum to justify maintaining the apps ourselves here.

If you've got the time, it would be great to start helping out with reviews and we'll start adding commit/contributor rights to your accounts as we see you get involved.

Going to fyi @samccone in case he starts seeing a few more folks helping with reviews :)

@howardroark
Copy link

I know one common pattern is that PRs tend to lack updates that keep the tests passing. Then they sit untouched for a long time.

Perhaps it would be helpful to setup a of bot which pokes all PRs where tests fail and there is no recent activity, then closes them if tests don't start to pass soon after.

@bernard-lin
Copy link

Sounds great! Thanks @addyosmani

@addyosmani
Copy link
Member Author

Cheers!

@howardroark

Perhaps it would be helpful to setup a of bot which pokes all PRs where tests fail and there is no recent activity, then closes them if tests don't start to pass soon after.

I'd be open to us experimenting with a bot like this. One challenge we regularly have is tests of the main repo being broken (the build currently is) which might be something we'd need to fix before introducing a bot.

@rickhallett
Copy link

I'm quite open to open source, but would be happy to have a go at looking at PR code reviews. I've spent a fair amount of time looking through PRs - if there are more explicit guidelines for code reviewing I would definitely be interested in digesting those. Thanks to @addyosmani for taking up lead of such a great project - it has been instrumental in my journey into programming, javascript and now open source!

@addyosmani
Copy link
Member Author

@WhiteFire0 Thanks! We've been fortunate to have a lot of help from @FadySamirSadek on reviewing PRs lately.

Would you like to start there (helping with code reviews or issues) and we can add you to the repo too if you feel comfortable with it after a bit?

@dtheb
Copy link

dtheb commented Jun 20, 2018

If you still have a spot available, I would love to help with what I can, especially issues and a little PRs reviewing.

@FadySamirSadek
Copy link
Collaborator

@ahmed-90 @WhiteFire0 Thank you for wanting to contribute to TodoMVC you can start by doing things like reviewing current open PRs and issue. Also, It will be great if you are able to finish some of the tasks we have for the next release on #1880. I am here if you need any help implementing any of these as I just finished my finals yesterday and now I have a lot more time to work on this project and with you. We can also chat on this project's gitter channel. Sorry if I took a long time to respond.

@debasree888
Copy link

If you still have one spot available, I would really love to help with what I can, especially issues and PRs reviewing.because by doing this i would get to know a lot of things

@rickhallett
Copy link

@addyosmani Absolutely; count me in! Feel free to add me to the repo - I will get on the Gitter channel when I get back this evening. @FadySamirSadek no problem on the delay!

@sr6033
Copy link

sr6033 commented Jun 20, 2018

I am all up for this. Will love to review the PRs, and help in closing or merging them and in reviewing different issues. I have worked with Javascript and its frameworks all up till now and it would be great helping you out in maintenance.

@rickhallett
Copy link

Apologies for the delay @FadySamirSadek - will get on these issues as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants