-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASPNET50 Core Support? #16
Comments
I haven't been able to build a Nuget with PCL support using the k build infrastructure. The current Nuget build process is still using the old infrastructure. It is high on my priority list to get all my libraries working in ASPNET5Core. I have not yet tried using ctp6. |
I don't think you can build a PCL with k. Sometimes it looks like it kind of works, but I don't think it is supported. This is the only recent reference I could find: I am glad I am not a package author, because there seems to be a lot of confusion as to how to build a package to support the different targets. I even tried looking at the EntityFramework source on github to see what they do and I couldn't make any sense of their build/test scripts. The good news is, if I build the current source with the project.json you put together, it seems to work fine, so I'll go that route for now. Sorry I can't offer anything else. |
I asked David Fowler about it and he said it should work. Maybe once they get Nuget v3 out thinks will be better. Thanks for your patience and your support. |
Any update on this one? |
I haven't tried it in a while. I downloaded the RTM of VS2015 yesterday and will get that installed soon. Hopefully that will help. Have you seen any posts from someone who has released their portable libs with dotnetcore support? |
No posts but I think json.net does it... |
Correct - JSON.NET would be a great way to look at how it's done. It looks like they kept their old process and then just added a project.json targeting the new "dotnet" Target Framework Moniker(TFM) I am not sure how JSON.NET does its build to create the Nuget package, because it looks like there are still a lot of legacy .csproj files laying around. There is some discussion here: aspnet/dnx#1894 regarding support for older frameworks with the beta8 release of ASPNET5. I'm still not sure what that means for PCLs because I don't use them much. If you can do something quick, I'm sure people would use it, but if it requires heroic efforts, I'd probably wait for beta8 since it looks like the story for package authors is going to improve. |
Ok, finally. The latest preview release 0.6.4-rc5 now compiles in CoreCLR in Visual Studio and via the command line. |
I noticed that it looks like you recently added ASPNET5 Core support (at least in the source), but if you did, I think something is wrong with the nuget package currently published. I get a compile error against ASPNET5 Core (works fine on ASPNET5):
When I cloned the source and directly referenced the project, everything seemed to work fine.
I've created a simple repo here to illustrate the issue:
https://github.com/npnelson/TavisURITemplateASPNet5Core.git
If you clone and build that with VS2015 CTP6, you should see the error.
It's not a big deal for me since I can build the source, but I just wanted to make sure you knew that there seems to be a problem with the current nuget package when using ASPNET5Core
P.S. I love your library.
The text was updated successfully, but these errors were encountered: