-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review requests for MDN docs for TC39 proposals #9
Comments
This issue looks empty, so let me start with something 😀. In Array.prototype.concat mdn page, it does not talk about ArraySpeciesCreate behavior. ArraySpeciesCreate uses the same constructor as "this" to create the output array. That is, if "this" is actually created from a subclass of Array - then what will be the type of the returned array. Say, Should we add this information to that page? Or is that more of a Implementation detail? |
It might be being removed soon, so that’s probably best not to document for now. |
So, what is likely to get removed? Constructor reuse and Also, one more nitpick from the description -
Is it clear enough from the text that - both "this" and other arguments will be treated in this way (either spreaded or appended as whole) ? |
Yes. “the elements in the object in which it is called” is the receiver (the |
But then, what happens if the receiver itself is not spreadable? Like From what i understand - the whole list of (receiver + all arguments) is treated in the same way - spread or append, not just the arguments. Which understanding is wrong? |
The same thing if an argument is not spreadable. They’re all treated the same, but MDN isn’t going into detail about the obscure edge case of using .call on a non-array. |
MDN is a wiki, so writing articles there can feel like sending it to a black hole.
In this thread, let's post links to our recently posted MDN articles or edits about TC39-related topics, so that others can see them and comment on them.
Use a 👍 GitHub react if you read something and it looks good, or @-mention the poster of the request to give review comments.
It's not clear whether a GitHub thread will work or something smaller like email threads would be better; let's not hesitate to switch to something else if this doesn't work out.
cc @sarahgp @shwetank @romulocintra @bkardell @chicoxyzzy @neilkakkar @vaidehijoshi @pipobscure
The text was updated successfully, but these errors were encountered: