Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid test based on Interface. #193

Open
tbremer opened this issue Jul 31, 2018 · 1 comment
Open

Invalid test based on Interface. #193

tbremer opened this issue Jul 31, 2018 · 1 comment

Comments

@tbremer
Copy link

tbremer commented Jul 31, 2018

In the Function arguments suite there is a test that requires the complete callback to take a value (https://github.com/tc39/proposal-observable/blob/master/test/subscribe.js#L41), however, the Observer interface does not specify it should take a value.

interface Observer {

    // Receives the subscription object when `subscribe` is called
    start(subscription : Subscription);

    // Receives the next value in the sequence
    next(value);

    // Receives the sequence error
    error(errorValue);

    // Receives a completion notification
    complete();
}

Moreover, the body of the Specification also indicates that it should not take a value (https://tc39.github.io/proposal-observable/#subscription-observer-prototype-complete).

So, what is valid? The test or the specification? Also, can we update the incorrect instances?

@benjamingr
Copy link

The test is outdated and needs a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants