Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to Intl.DurationFormat #3912 #4168

Open
ptomato opened this issue Jul 24, 2024 · 0 comments
Open

Follow-up to Intl.DurationFormat #3912 #4168

ptomato opened this issue Jul 24, 2024 · 0 comments

Comments

@ptomato
Copy link
Contributor

ptomato commented Jul 24, 2024

Address comments from #3912.

  • test/intl402/DurationFormat/constructor-option-read-order.js: localeMatcher is read before numberingSystem but isn't in resolvedOptions(). Probably better to use a Proxy that pushes all Get operations to the array, rather than just the ones in resolvedOptions().
  • test/intl402/DurationFormat/prototype/resolvedOptions/return-keys-order-default.js: fractionalSeconds is added last if not undefined. Consider testing the order again when constructing the object with e.g. new Intl.DurationFormat('en', { fractionalDigits: 0 }).

cc @FrankYFTang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant