Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Location (fr: Localisation) #75

Closed
estellecomment opened this issue Jun 28, 2022 · 5 comments
Closed

Disable Location (fr: Localisation) #75

estellecomment opened this issue Jun 28, 2022 · 5 comments
Assignees
@jdauphant
Labels
need-for-security P1 Priority 1 proposal to element web

Comments

@estellecomment
Copy link
Contributor

estellecomment commented Jun 28, 2022 •
edited
Loading

Because we have no map server.
We do not use the default map server, because we need to own all data exchanges for security.

Mobile clients have disabled it as well.
@github-actions github-actions bot added the web label Jun 28, 2022
@estellecomment
Copy link
Contributor Author

We have added etalab's map server as an experiment in #81 . https://openmaptiles.geo.data.gouv.fr/

Their service gives no guarantees of performance/availability, and is not homologué.
Etalab thinks it would make more sense if IGN provided this service.
Documentation and links to IGN services : https://guides.etalab.gouv.fr/apis-geo/3-tuiles-vecteur.html#comment-utiliser-les-tuiles-vectorielles-d-etalab

@jdauphant jdauphant added P1 Priority 1 need-for-security P2 Priority 2 and removed P1 Priority 1 labels Jul 6, 2022
@jdauphant
Copy link
Contributor

It's not possible to disable localisation, we have some edition in react-sdk to do that apparently

@estellecomment estellecomment changed the title Disable Localisation Disable Location (fr: Localisation) Jul 18, 2022
@estellecomment
Copy link
Contributor Author

We can add a UIFeature for location, and check it here :
https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/rooms/MessageComposer.tsx#L473

@estellecomment
Copy link
Contributor Author

What happens if we just remove the mapserver from the config ?
Is the feature properly hidden ?

@jdauphant
Copy link
Contributor

We got an exception if map_style_url is undefined : https://github.com/matrix-org/matrix-react-sdk/blob/1397652f526cada5b87cc8dccaa76fa49e39d0cb/src/utils/location/findMapStyleUrl.ts#L37

@odelcroi odelcroi added P1 Priority 1 and removed P2 Priority 2 labels Sep 1, 2022
@jdauphant jdauphant mentioned this issue Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdauphant jdauphant

Labels
need-for-security P1 Priority 1 proposal to element web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@estellecomment @jdauphant @odelcroi