FixtureRollback vs @magentoDbIsolation

[bartoszkubicki]

First of all many thank for this awesome library - today I was able to setup scenario for reordering single order item within 15 minutes, while using your library for the first time!

I have a question though, about FixtureRollback classes and mentioned annotation. Is it necessary to use rollback, if we mark test with db isolation? Isn't it all performed in db transaction?

[schmengler]

Thank you, good to hear!

It's true, if you run your test in db isolation, rollback is not necessary, and using db isolation is generally a safe practice.

Sometimes there are reasons not to, though. For example, if indexing happens during tests, it doesn't work because temporary tables cannot be created inside a transaction. In Magento 2.2 the transaction would be silently committed, in 2.3 there's an exception.

You can see how I handle this for product fixtures here: c67e0fd

I'll leave this issue open as request for documentation