[Operator] strategyType not generated properly

[Janaka-Steph]

In generated file operator_pb_d.ts, strategyType has a typo trategyType which results in type being any when used in frontend.

  getStrategyType(): trategyType;
  setStrategyType(value: trategyType): UpdateMarketStrategyRequest;

export namespace MarketInfo {
  export type AsObject = {
    market?: types_pb.Market.AsObject,
    fee?: types_pb.Fee.AsObject,
    tradable: boolean,
    strategyType: trategyType,
    accountIndex: number,
    price?: types_pb.Price.AsObject,
    balance?: types_pb.Balance.AsObject,
  }
}

etc..

[tiero]

can you help us replicate how you compiling the stubs from protobuf? If you have any script or something

[Janaka-Steph]

Also happens we ActionType, being ctionType.

export namespace AddWebhookRequest {
  export type AsObject = {
    endpoint: string,
    action: ctionType,
    secret: string,
  }
}

Maybe a coincidence but both have Type in their name.

[Janaka-Steph]

This is the compiling script

#!/usr/bin/env bash

cd ./src/api-spec || exit
mkdir -p generated/js

GRPC_TOOLS_NODE_PROTOC="../../node_modules/.bin/grpc_tools_node_protoc"
GRPC_WEB_PLUGIN="../../node_modules/.bin/protoc-gen-grpc-web"

${GRPC_TOOLS_NODE_PROTOC} \
--js_out=import_style=commonjs,binary:./generated/js \
--grpc-web_out=import_style=typescript,mode=grpcwebtext:./generated/js \
--plugin=protoc-gen-grpc-web=${GRPC_WEB_PLUGIN} \
./*.proto

Using grpc-web "^1.2.1"

[Janaka-Steph]

Related issues
grpc/grpc-web#939
grpc/grpc-web#1039

[tiero]

need to lock 1.2.0