Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asyncio login #474

Open
tulir opened this issue May 6, 2019 · 1 comment
Open

Asyncio login #474

tulir opened this issue May 6, 2019 · 1 comment
Labels
component-core type-enhancement

Comments

@tulir
Copy link

tulir commented May 6, 2019

All the login stuff seems to be synchronous, which makes it hard to use properly from an asyncio context. Especially login needing callbacks (CredentialsPrompt) makes it nearly impossible.

The default prompt could still use the synchronous input even if the login stuff was asyncio, but custom asyncio prompts can't be used when the rest is synchronous.
@tdryer
Copy link
Owner

tdryer commented May 9, 2019

Right now auth is using mechanicalsoup which is synchronous-only. If we drop the automatic login method in the future, it should be easy enough to port to async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-core type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdryer @tulir