Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-MEASURE_VALIDATIONTESTS_NOTCOMPLIANT #31

Open
iDigBioBot opened this issue Jan 5, 2018 · 13 comments
Open

TG2-MEASURE_VALIDATIONTESTS_NOTCOMPLIANT #31

iDigBioBot opened this issue Jan 5, 2018 · 13 comments
Labels
CORE TG2 CORE tests Measure NAME OTHER SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 TIME

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 453844ae-9df4-439f-8e24-c52498eca84a
Label MEASURE_VALIDATIONTESTS_NOTCOMPLIANT
Description A count of the number of distinct VALIDATION tests that have a Response.status="NOT_COMPLIANT" for a given record.
TestType Measure
Darwin Core Class bdq:Validation
Information Elements ActedUpon
Information Elements Consulted bdq:AllValidationTestsRunOnSingleRecord
Expected Response INTERNAL_PREREQUISITES_NOT_MET if no tests of type VALIDATION were attempted to be run; REPORT of the number of tests of output type VALIDATION run against the record that have Response.result="NOT_COMPLIANT"
Data Quality Dimension Reliability
Term-Actions VALIDATIONTESTS_NOTCOMPLIANT
Parameter(s)
Source Authority
Specification Last Updated 2024-08-22
Examples [Response.status=RUN_HAS_RESULT, Response.result="37", Response.comment="37 VALIDATION tests had Response.status="NOT_COMPLIANT."]
Source Lee Belbin
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes We have three individual measures for pass (MEASURE_VALIDATIONTESTS_COMPLIANT (45fb49eb-4a1b-4b49-876f-15d5034dfc73)), fail (MEASURE_VALIDATIONTESTS_NOTCOMPLIANT (453844ae-9df4-439f-8e24-c52498eca84a)), and PREREQUISITES_NOT_MET (49a94636-a562-4e6b-803c-665c80628a3d). To get the total number of tests that were attempted, add all three measures. To get the total number of tests that ran, add NOT_COMPLIANT (fail) and COMPLIANT (pass).
@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Either we are using the framework or we are not. If we are using the framework, we must be consistent with it. Validations have results COMPLIANT or NOT_COMPLIANT. Validations have result status values that inform whether the test produced a result or whether for some reason it was not able to run. Therefore we need measures at the data set level of proportion of data compliant, proportion of data not compliant, and proportion of data where the validation could not be run.

@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Name should reflect single-record nature

@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Test name should reflect the framework: SINGLE_RECORD_VALIDATION_COMPLIANT_COUNT or something like that.

@godfoder godfoder changed the title TG2-MEASURE_VALIDATIONTESTS_NOTCOMPLIANT TG2-MEASURE_VALIDATIONTESTS_FAILED Jan 19, 2018
@godfoder
Copy link
Contributor

@chicoreus Does this look OK to you?

@chicoreus
Copy link
Collaborator

Single or MultiRecord? See comment by @ArthurChapman in #134

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 8, 2018

@ArthurChapman, as per #134, this is a SINGLE RECORD test (and the resulting count can be accumulated across multiple record/datasets/collections etc).

@Tasilee Tasilee changed the title TG2-MEASURE_VALIDATIONTESTS_FAILED TG2-MEASURE_VALIDATIONTESTS_NOTCOMPLIANT Mar 23, 2018
@tucotuco
Copy link
Member

I suggest the Description:

'The number of distinct VALIDATION tests that have a Response.status="NOT_COMPLIANT" for a given record.'

in place of:

'The number of VALIDATION type tests run on a record that have a Response.status="NOT_COMPLIANT".'

@ArthurChapman
Copy link
Collaborator

Updated wording of Notes to be consistent with #134 and #135 and to removed internal GitHub cross references.

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 16, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
@chicoreus
Copy link
Collaborator

AllDarwinCoreTerms needs to be replaced by a list of relevant validations, in the form (used in the multirecord measures):

bdq:VALIDATION_BASISOFRECORD_NOTEMPTY.Response, as it is the results of validations on the single records that are the information elements for this test, not the darwin core terms.

We should probably also split this test into one test for each use case, with information elements matching the validations found in that use case.

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 18, 2024

I agree @chicoreus , but there are two issue. First up, we probably should not list CORE VALIDATION tests as these may change depending on context. Second, we don't agree about splitting on use case.

I have changed Information Element Consulted from "All DarinCoreTerms" to "All CORE tests of type VALIDATION that were run"

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 18, 2024

Changed Information Elements Consulted to "bdq:AllValidationTestRunOnSingleRecord"

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 22, 2024

Changed Expected Response from

INTERNAL_PREREQUISITES_NOT_MET if no tests of type VALIDATION were attempted to be run; REPORT of the number of tests of output type VALIDATION run against the record that have Response.result="NOT_COMPLIANT"; otherwise NOT_REPORTED

to

INTERNAL_PREREQUISITES_NOT_MET if no tests of type VALIDATION were attempted to be run; REPORT of the number of tests of output type VALIDATION run against the record that have Response.result="NOT_COMPLIANT"

as you can't reach "NOT_REPORTED" anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE TG2 CORE tests Measure NAME OTHER SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 TIME
Projects
None yet
Development

No branches or pull requests

6 participants