Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -q, --quiet flag to surpress non-error output #48

Closed
wants to merge 8 commits into from

Conversation

jedahan
Copy link
Contributor

@jedahan jedahan commented Sep 17, 2018

First pass at #46, tests pass and manual testing looked good.

@dbrgn
Copy link
Collaborator

dbrgn commented Sep 17, 2018

Thanks, that was fast :) PR looks good.

The README is missing an update with the new command. Furthermore, I currently prefer if the version bump is only done on release. But I can fix these two issues myself.

Edit: Oh and there was a typo: surpress should be suppress :)

@dbrgn
Copy link
Collaborator

dbrgn commented Sep 17, 2018

One more thing: Could you add a few small tests for this? You can take a look at tests/lib.rs for reference, for example test_missing_cache. Thanks to assert_cli it's very simple to call the binary and to verify the output.

@jedahan
Copy link
Contributor Author

jedahan commented Sep 17, 2018

K, added tests. A bit hacky but seem to work.

@dbrgn
Copy link
Collaborator

dbrgn commented Sep 18, 2018

Nice, thanks @jedahan!

dbrgn pushed a commit that referenced this pull request Sep 18, 2018
@dbrgn
Copy link
Collaborator

dbrgn commented Sep 18, 2018

Merged in 8784b55.

@dbrgn
Copy link
Collaborator

dbrgn commented Sep 18, 2018

@jedahan Ok, all open pull requests have been merged. I'll leave for 2 weeks of vacation tomorrow, some testing would be welcome during that time. If everything works, I plan to make the next release early October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants