Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (back) support for proxies #68

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Add (back) support for proxies #68

merged 2 commits into from
Nov 22, 2018

Conversation

aldanor
Copy link
Contributor

@aldanor aldanor commented Nov 22, 2018

@aldanor aldanor mentioned this pull request Nov 22, 2018
Closed
@aldanor
Copy link
Contributor Author

aldanor commented Nov 22, 2018 •
edited
Loading

Actually, hold on; do we want to bail if creating Proxy() from env fails? I would be inclined not to.

Upd: ok, fixed now.

@dbrgn
Copy link
Collaborator

dbrgn commented Nov 22, 2018

I would be inclined not to.

Yes, I agree 🙂

Thank you!

@dbrgn dbrgn merged commit f3cabdd into tealdeer-rs:master Nov 22, 2018
@dbrgn dbrgn mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrgn dbrgn dbrgn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldanor @dbrgn