Windows support #77
Merged
Windows support #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to enable ANSI color support on Windows using the new APIs. If that succeeds, we print colors as usual. If it fails, we disable styles completely.
mystal
force-pushed
the
windows-support
branch
from
8b1b4c0
to
495c3e9
Compare
|
@mystal thanks a lot for the PR! 🚀 I'm quite busy at the moment, but will try to take a look at the PR this week. Should I forget, please ping me! |
|
@dbrgn Quick ping, as requested :) |
Closed
|
Finally, looks good now! Thanks @mystal and sorry for the delay. Last request, in #59 you wrote:
I think this could be configured with the .gitattributes file, could you verify that? |
|
Oh yeah, looks like a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work from #59.