Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in openshift rolebinding #17

Open
sebgoa opened this issue Jun 28, 2019 · 3 comments
Open

Panic in openshift rolebinding #17

sebgoa opened this issue Jun 28, 2019 · 3 comments

Comments

@sebgoa
Copy link

sebgoa commented Jun 28, 2019

In openshift, rolebindings can have an entry userNames: null

The parsing panics because this is not a string

@luksa
Copy link
Collaborator

luksa commented Jun 28, 2019

@sebgoa are you sure? We don't even parse the userNames or the groupNames fields (which we probably should). I've tried visualizing the system:image-pullers role binding, which has userNames: null and it seems to work fine.

@sebgoa
Copy link
Author

sebgoa commented Jun 30, 2019

This was an openshift 3.11 cluster wtih standard rolebindings. Unfortunately I don't have access to the platform anymore and could not dump the roles in here. I assumed this was due to the userNames but I definitely don't know for sure.

I just add panics when running rback saying that it could not "parse" int.

@gparvin
Copy link
Contributor

gparvin commented Sep 8, 2020

I don't have an openshift 3.11 environment right now but I made a PR to fix what sounds like a similar issue in openshift 4: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants