You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If \Tripod\Exception is renamed (let's say to FooException) it's really clear the code above is not going to capture it.
At the moment a glance, especially in a PR where the file header might be suppressed from view, it's not clear which flavour of exception the above code is capturing.
If you're editing a file which uses
\tripod\exceptions
this doesn't do what you think it does:It actually catches
\tripod\exceptions\Exception
, not\Exception
. Rename the former to be more specific and less bug-prone.The text was updated successfully, but these errors were encountered: