Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support docker #174

Merged

Conversation

muhammad-asn
Copy link
Contributor

@muhammad-asn muhammad-asn commented Jul 14, 2024

Add support for Docker

Copy link

vercel bot commented Jul 14, 2024

@muhammad-asn is attempting to deploy a commit to the technikhil314's projects Team on Vercel.

A member of the Team first needs to authorize it.

@muhammad-asn
Copy link
Contributor Author

@technikhil314 Please kindly check this PR. It will enable the offline-diff-viewer to run as a container-based application.

@technikhil314
Copy link
Owner

Just trying to understand the use case here. Isnt just going to site and seeing the diff there more easy and convenient? @muhammad-asn

@muhammad-asn
Copy link
Contributor Author

Just trying to understand the use case here. Isnt just going to site and seeing the diff there more easy and convenient? @muhammad-asn

I think It will help if someone want to deploy (self-hosted) using containerization.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
nuxt.config.js Outdated Show resolved Hide resolved
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
offline-diff-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 11:17am

@technikhil314 technikhil314 merged commit b52e530 into technikhil314:develop Jul 27, 2024
2 checks passed
technikhil314 added a commit that referenced this pull request Jul 27, 2024
* fix: added missing titles in diffview of v2

* fix: using v2 link for sample link in docs

* feat: support docker (#174)

* feat: add docker

* fix: nginx failed to load

* docs: update README.md

* chore: change to npm ci and remove static in nuxt.config.js

* docs: update server to serve

* docs: add Self Host section

---------

Co-authored-by: Nux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants