Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE_PR doesnt seem to be working with on:push #380

Open
guergana opened this issue Oct 25, 2023 · 1 comment
Open

CREATE_PR doesnt seem to be working with on:push #380

guergana opened this issue Oct 25, 2023 · 1 comment
Assignees

Comments

@guergana
Copy link

guergana commented Oct 25, 2023

Describe the bug: バグの概要

The action creates a commit properly but given the flag CREATE_PR it doesn't create a PR with the ToC.
This was tested when pushing to a specific folder. I don't know if the CREATE_PR flag is working when no folder is specified.

To Reproduce: 再現手順

Steps to reproduce the behavior:

  1. Create a workflow that uses the CREATE_PR flag:
 name: Update Table of Contents (ToC)

on: 
  push:
    paths: 
      - docs/**

jobs:
  generateTOC:
    name: TOC Generator
    runs-on: ubuntu-latest
    steps:
      - uses: technote-space/toc-generator@v4
        with:
          CREATE_PR: true
          TARGET_PATHS: ./docs/*.md
  1. Push some changes to specified folder. The workflow will run and create a commit at the end of the PR that created the changes in the folder.
  2. Check github, the create PR prompt is not triggered.

Expected behavior: 期待する動作

A PR is opened with on:push event.

The flag works with on:pull_request event.

Additional context: 補足

This was tested on the following PR: wmde/wikidata-mismatch-finder#720

@welcome
Copy link

welcome bot commented Oct 25, 2023

🙌 Thanks for opening your first issue here! Be sure to follow the issue template!

@guergana guergana changed the title CREATE_PR doesnt seem to be working CREATE_PR doesnt seem to be working with on:push Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants