Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to work with YubiKey after UIUC IdP upgrade #25

Closed
ddriddle opened this issue Feb 28, 2019 · 5 comments
Closed

Fails to work with YubiKey after UIUC IdP upgrade #25

ddriddle opened this issue Feb 28, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ddriddle
Copy link
Collaborator

Previously, we used a separate module that used the following headers:

X-Shiboleth-Duo-Factor
X-Shiboleth-Duo-Passcode

The new Shibboleth IdP 3.4 changed the header names:

X-Shibboleth-Duo-Factor
X-Shibboleth-Duo-Passcode

We need to make the headers configurable by the end user.

@ddriddle
Copy link
Collaborator Author

ddriddle commented Mar 4, 2019

+++ /Users/ddriddle/.pyenv/versions/3.5.2/lib/python3.5/site-packages/awscli_login/config.py	2019-02-28 15:54:09.000000000 -0600
@@ -281,9 +281,9 @@
             self.raise_if_factor_invalid()
 
         if self.is_factor_valid():
-            headers['X-Shiboleth-Duo-Factor'] = self.factor
+            headers['X-Shibboleth-Duo-Factor'] = self.factor
             if not first_pass or self.factor == 'passcode':
-                headers['X-Shiboleth-Duo-Passcode'] = input('Code: ')
+                headers['X-Shibboleth-Duo-Passcode'] = input('Code: ')
 
         return self.username, self.password, headers
 

@dmrzzz
Copy link

dmrzzz commented Mar 22, 2019

It looks like you already have a solution to bring the headers in line with latest IdP. Any chance we could get an updated release?

@ddriddle
Copy link
Collaborator Author

@dmrzzz expect an update be the end of the week.

@sosumi
Copy link

sosumi commented Apr 30, 2019

In addition to this issue, it appears that there may be a bug in the default Duo configuration for the Shibboleth IdP that would prevent the selection of "passcode" as a factor. See: https://issues.shibboleth.net/jira/browse/IDP-1448 and https://issues.shibboleth.net/jira/browse/IDP-1425

@ddriddle
Copy link
Collaborator Author

The release 0.1.0a6 of awscli-login resolves this issue. Sorry for the delayed release.

@ddriddle ddriddle added the bug Something isn't working label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants