-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent order of operations #232
Comments
We need to document - implementation sorts keys - https://github.com/teemtee/fmf/blob/29190c78e4065adf98cbb3ccf747b01973d761e2/fmf/base.py#L222C1-L222C50 |
Oh, thanks for the info. Than the only other part of the issue is if there are tests that cover the plain order, the order with inheritance and the order with |
Ack, coverage should be added as mistakes in refactor might happen. |
Hm, just pondering, is that |
Decision from the hacking session: Respect the order of the adjustments and drop the |
Could break backwards compatibility, but I think this is quite a niche usage, we could just scrape the public Edit: as far as I see we're safe: https://sourcegraph.com/search?q=context:global+file:.*%5C.fmf+%28%5Cw%2B%29%28-%7C%5C%2B%3C%29:&patternType=regexp&sm=0 |
Example:
This one gives
my_var: one and four
which would be inconsistent based on the order of definition. This might not be that crucial, but at least it should be documented that the keys are ordered before being parsed by fmf, thus the order is ...Are there tests at least covering the operation order based on inheritance (inherited operations occur first, e.g. if
my_var-:
was one level below,three
should be in the list) and adjust (after base variable operations)?The text was updated successfully, but these errors were encountered: