Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Tasks: Move all Run-related Go types to pkg/apis/run #3596

Open
GregDritschler opened this issue Dec 3, 2020 · 7 comments
Open

Custom Tasks: Move all Run-related Go types to pkg/apis/run #3596

GregDritschler opened this issue Dec 3, 2020 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@GregDritschler
Copy link
Contributor

Feature request

This is a follow-on to #3463. That PR created a new package pkg/apis/run/v1alpha1 to solve circular dependency issues between pkg/apis/pipeline/v1alpha1 and pkg/apis/pipeline/v1beta1. Only RunStatus was moved to the new package because moving the other Run-related types required a fair amount of refactoring to other Tekton types.

Use case

This affects consumers of the Tekton API who may find it confusing that the Run-related types are split across different packages.

@GregDritschler GregDritschler added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 3, 2020
@GregDritschler
Copy link
Contributor Author

I will work on this after #3463 is merged.

@GregDritschler
Copy link
Contributor Author

I investigated this further. The problem I am running into now is that the tools that generate the client, listers, informers, and reconciler do not support type aliases. So moving Run completely to a new package means these generated artifacts also change packages with no easy way to keep aliases around in the old package for compatibility. Since the kubeflow team is already implementing custom task controllers that use these artifacts, I am not in favor of making this breaking change.

@ghost
Copy link

ghost commented Jan 13, 2021

Should we keep this open with a view to consolidating the types in a single package when we move the feature into beta?

@GregDritschler
Copy link
Contributor Author

Should we keep this open with a view to consolidating the types in a single package when we move the feature into beta?

Yeah I had a similar thought, though I was thinking in terms of a v1 restructure (probably the next big refactoring).

@ghost ghost modified the milestones: Pipelines 0.21, Pipeline v1beta2 Jan 25, 2021
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2021
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 25, 2021
@jerop
Copy link
Member

jerop commented Jun 1, 2021

ongoing work
/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

5 participants