Cleanup for PipelineRunStatus Migration after EmbeddedStatus Feature Flag is removed

[JeromeJu]

This issue tracks the cleanup after v0.45 post the EmbeddedStatus feature flag is removed.

• Cleanup previous guards for status.taskruns or status.runs for full or both embedded-status
  - for example:

  pipeline/pkg/reconciler/pipelinerun/pipelinerun.go

  Line 1404 in ea358a6

  // Verify that we don't populate child references for "full"

• Remove status.taskruns and status.runs from the codebase
• Refactor the helper functions that has been cut after the removal of the feature flag as they might be combined
• Clean up the pkg/status package or not?

This was not cleaned up in v0.45 as now users might be in the progress of migrating off the embedded-status feature flag.

[JeromeJu]

/assign

[JeromeJu]

I also noticed #4850 for changes in pkg/status, I think these should be kept specifically for those who wants to populate full/ both like PipelineRunStatus? So probably I should not even rename the functions nor the test cases in pkg/status when removing the Embedded-status?

cc @abayer could you help confirm my understanding on this, TY🙇‍♂️

[lbernick]

When we remove the feature flag, we're no longer populating those fields, so it doesn't make sense to have the helpers continue to read from them

[JeromeJu]

Thanks Lee! That makes sense, so shall we go ahead and delete the package pkg/status?

[lbernick]

Let's leave the helpers there, but they should only read from childreferences