Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/update-deps.sh script removes third_party directory #6352

Closed
EmmaMunley opened this issue Mar 13, 2023 · 1 comment · Fixed by #6416
Closed

hack/update-deps.sh script removes third_party directory #6352

EmmaMunley opened this issue Mar 13, 2023 · 1 comment · Fixed by #6416
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@EmmaMunley
Copy link
Contributor

Expected Behavior

Run hack/update-codegen.sh to update pipeline-api.md.

Actual Behavior

Deletes over 200 license files.

https://github.com/tektoncd/pipeline/compare/54d617d4273807a33c029b9121bc181a736413f3..5c3944dea8f4029af6e28aeb3542451df52f0006

Workaround run hack/update-reference-docs.sh directly.

Steps to Reproduce the Problem

  1. Run `hack/update-codegen.sh

Additional Info

  • Kubernetes version:

    Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.4", GitCommit:"872a965c6c6526caa949f0c6ac028ef7aff3fb78", GitTreeState:"clean", BuildDate:"2022-11-09T13:36:36Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.7
  • Tekton Pipeline version:

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.29.0
@EmmaMunley EmmaMunley added the kind/bug Categorizes issue or PR as related to a bug. label Mar 13, 2023
@lbernick
Copy link
Member

Thanks for filing! I'm running into this as well in #6342, and I believe the problem is with hack/update-deps.sh specifically. (I hope you don't mind me retitling the issue!) I suspect this has to do with whether the repo is in your gopath or not.

@lbernick lbernick changed the title hack/update-codegen.sh script isn't running hack/update-reference-docs.sh hack/update-deps.sh script removes third_party directory Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants