-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split examples out to a new repo #649
Comments
cc @bobcatfish any other concerns to think through here? |
Strawman for tests: Each example pipeline/task must also specify a Our test runner then goes:
|
@dlorenc I'm very much for a à-la- On tests, additionally, if we setup some CI on this repository, we would need some daily build with current release and/or current master 💃 On updating them with API changes, it's gonna be a good exercise for us (to hopefully not break them often and later on to have clear upgrade path) |
I like the idea of a separate repo. I think we'll need to have some type of cross-testing: we could run the examples against API changes as part of the This brings two benefits: keep the examples in a working state, help notice API breaking changes that might be missed by review. |
Now that we've got https://github.com/tektoncd/catalog can we close this @dlorenc ? (or we could leave it open assuming we want to move our |
|
hm interesting idea @vdemeester ! i'm having trouble thinking of any other names - I wouldn't want to move these to Do you have any ideas? 🙆♀️ |
No clear ideas yet. There will be the catalog for a extensive examples of each task but we still need executable examples here (to catch potential regression, etc.). |
@dlorenc @bobcatfish what should we do for this ? We will have more example on the docs for sure, and we have the catalog for the shareable tasks. /kind question |
I feel like we should close this? Maybe open another issue to discuss anything specific that came from this issue. |
This is a proposal to move examples to a separate repo. Currently we have examples in this repo, but this might lead to a few issues eventually:
Some ideas to think through:
The text was updated successfully, but these errors were encountered: