Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Metrics for the Deprecated CloudEvents #6826

Closed
JeromeJu opened this issue Jun 14, 2023 · 2 comments · Fixed by #6827
Closed

Cleanup Metrics for the Deprecated CloudEvents #6826

JeromeJu opened this issue Jun 14, 2023 · 2 comments · Fixed by #6827

Comments

@JeromeJu
Copy link
Member

CloudEvents for Taskrun Status are deprecated and not moved to V1. And the functionalities for it to be part of the metrics is also deprecated when we remove the PipelineResources at [TEP074] Remove CloudEvent pipelineResources. We should cleanup the logics for it in the reconciler.

related: #6444 (comment)
@JeromeJu
Copy link
Member Author

cc @afrittoli @dibyom @lbernick

This was referenced Jun 14, 2023
Merged
Merged
@JeromeJu
Copy link
Member Author

JeromeJu commented Jun 14, 2023 •
edited
Loading

To check my understanding, we are removing the metrics for CloudEvents which are not apparent in TaskRun status when moving to v1. But for the actual cloudEvents being emitted we wouldn't want to remove them for the time being? (which is not related with #6444 and could be done in a followup PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@JeromeJu