-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial type defintions #10
Comments
Closed prematurely, theres still items to address despite the PR being merged 😅 |
@iancoffey What work is still left under this issue? Is it the work outlined in this comment? |
@ncskier Yes, I just wanted to make sure I made followup issues if they didnt exist for each of those items (which I have not done yet). Totally cool with closing if thats not needed, or I will check that out tomorrow. |
Ok, sounds good! I was just looking over the issues for another one to pick up, and I wasn't positive what was left to do for this one 😁That would be great if you could create new issues documenting the remaining work 👍 |
This is long since merged, Im going to close this one. |
Expected behavior
We should have the structure of the types we want to add for Tekton Triggers clearly defined in this repo and agreed on by all owners:
EventListener
TriggerBinding
TriggerTemplate
Each type should:
go
such that it can be fed toupdate-codegen.sh
examples
dir (even if we aren't testing this yet, see Add automated coverage for examples #11)Actual behavior
The structure of the types is basically just in exist in example yaml in the design doc which means that:
Additional info
Design for these types lives in https://docs.google.com/document/d/1fngeNn3kGD4P_FTZjAnfERcEajS7zQhSEUaN7BYIlTw/edit (visible to members of tekton-dev)
The text was updated successfully, but these errors were encountered: