Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TriggerResourceTemplate Spec #32

Closed
iancoffey opened this issue Jul 23, 2019 · 1 comment
Closed

Implement TriggerResourceTemplate Spec #32

iancoffey opened this issue Jul 23, 2019 · 1 comment
Assignees
@vtereso
Milestone
Triggers 0.1

Comments

@iancoffey
Copy link
Member

iancoffey commented Jul 23, 2019 •
edited by vtereso
Loading

The initial types PR did not implement the TriggerResourceTemplate.

https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/trigger_template_types.go#L30

Acceptance criteria

The TriggerTemplate has a functional TriggerResourceTemplate and controller logic to handle creating the objects.
@iancoffey iancoffey mentioned this issue Jul 23, 2019
Merged
3 tasks
@vtereso
Copy link

vtereso commented Jul 23, 2019

/assign

@vtereso vtereso closed this as completed Aug 6, 2019
@bobcatfish bobcatfish added this to the Triggers 0.1 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtereso vtereso

Labels
None yet
Projects
None yet
Milestone
Triggers 0.1
Development

No branches or pull requests
3 participants
@bobcatfish @iancoffey @vtereso