Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels should be rendered via helpers #519

Closed
robholland opened this issue Jul 2, 2024 · 1 comment
Closed

Labels should be rendered via helpers #519

robholland opened this issue Jul 2, 2024 · 1 comment
Assignees
@sahilvv
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.0

Comments

@robholland
Copy link
Contributor

Is your feature request related to a problem? Please describe.

All the templates have the same label blocks and selector patterns. Labels are often repeated multiple times (Deployment spec and deployment's pod spec, etc).

Describe the solution you'd like

Labels should be rendered via a helper so that templates are cleaner and it's easier to ensure consistency of labels/selectors.

Additional context
@robholland robholland added enhancement New feature or request good first issue Good for newcomers labels Jul 2, 2024
@robholland robholland added this to the 1.0 milestone Jul 6, 2024
@sahilvv
Copy link
Contributor

sahilvv commented Jul 8, 2024

I would like to work on this issue

@sahilvv sahilvv mentioned this issue Jul 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahilvv sahilvv

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@robholland @sahilvv