Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Custom Resource Labels seems to be broken after 0.45.0 #575

Closed
VLZZZ opened this issue Oct 1, 2024 · 0 comments · Fixed by #576
Closed

[Bug] Custom Resource Labels seems to be broken after 0.45.0 #575

VLZZZ opened this issue Oct 1, 2024 · 0 comments · Fixed by #576
Labels
bug Something isn't working

Comments

@VLZZZ
Copy link
Contributor

VLZZZ commented Oct 1, 2024

What are you really trying to do?

Hi there!

I'm experiencing issues after #539 was introduced in 0.45.0

Describe the bug

Additional custom PodLabels being merged to the previous line (at least for web and admintools in my case)

We have custom PodLabel set like this in values.yaml

admintools:
    podLabels:
      grafana.xxx.com/component-type: infra

Which resulted in (output of helm template command)

  template:
    metadata:
      labels:
        app.kubernetes.io/component: admintools
        app.kubernetes.io/name: temporal
        helm.sh/chart: temporal-0.45.0
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/instance: release-name
        app.kubernetes.io/version: "1.25.0"
        app.kubernetes.io/part-of: temporalgrafana.xxx.com/component-type: 
infra

and corresponding mapping error:

 error converting YAML to JSON: yaml: line 29: mapping values are not allowed in this context

Environment/Versions

  • Temporal Version: temporaHelm-chart version 0.44.0
  • Kubernetes

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant