Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grafana dependency #526

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BrianKopp
Copy link

What was changed

Removed Grafana dependency and related config.

Why?

Configuration & installation of monitoring tools is a cluster-level consideration, and shouldn't be specified in an application such as this.

Checklist

  1. Closes [Feature Request] Remove dependency on Grafana #518

  2. How was this tested:
    Diff between helm template main and this branch has no differences.

Note - if running helm from the directory or source, and if you don't run helm dependencies update, then helm will want to install grafana since it's enabled by default.

  1. Any docs updates needed?

README is updated.

This will be a breaking change for folks who have grafana enabled, since it will delete their temporal-installed-grafana.

@BrianKopp BrianKopp requested a review from a team as a code owner July 5, 2024 13:35
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Brian Kopp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove dependency on Grafana
3 participants