Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add DD_SITE env var to promql-to-dd-go Helm example #95

Open
jyanadi opened this issue Nov 5, 2024 · 0 comments · May be fixed by #96
Open

[Feature Request] Add DD_SITE env var to promql-to-dd-go Helm example #95

jyanadi opened this issue Nov 5, 2024 · 0 comments · May be fixed by #96
Labels
enhancement New feature or request

Comments

@jyanadi
Copy link

jyanadi commented Nov 5, 2024

Is your feature request related to a problem? Please describe.

We are trying to send Temporal metrics to DD using the example Helm Chart with ArgoCD. Since our organization is on a non-default Datadog site, the metrics are not being received by us (they are sent to the default datadoghq.com site). and the current version of the deployment.yaml does not support setting DD_SITE env var.

Describe the solution you'd like

Having the ability to set the DD_SITE env var from Helm value (dd_site) will fix the problem

env:
   - name: DD_SITE
     value: {{ .Values.dd_site }}

Additional context

The other observability examples all expose the DD_SITE env var. Only the golang solution is missing this.

@jyanadi jyanadi added the enhancement New feature or request label Nov 5, 2024
@jyanadi jyanadi linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant