From 485ae99839db9a519838656b7ad2e79422fed708 Mon Sep 17 00:00:00 2001 From: Alex Shtin Date: Wed, 27 Jan 2021 20:06:04 -0800 Subject: [PATCH] Accept empty Kafka config when visibility queue is set to internal (#1238) --- temporal/server.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/temporal/server.go b/temporal/server.go index 02f674e2070..d10c4ca3538 100644 --- a/temporal/server.go +++ b/temporal/server.go @@ -290,8 +290,12 @@ func (s *Server) getServiceParams( dynamicconfig.AdvancedVisibilityWritingMode, common.GetDefaultAdvancedVisibilityWritingMode(s.so.config.Persistence.IsAdvancedVisibilityConfigExist()), )() + visibilityQueue := dc.GetStringProperty( + dynamicconfig.VisibilityQueue, + common.VisibilityQueueInternal, + )() isAdvancedVisEnabled := advancedVisMode != common.AdvancedVisibilityWritingModeOff - if isAdvancedVisEnabled { + if isAdvancedVisEnabled && (visibilityQueue == common.VisibilityQueueKafka || visibilityQueue == common.VisibilityQueueInternalWithDualProcessor) { params.MessagingClient = messaging.NewKafkaClient(&s.so.config.Kafka, metricsClient, zap.NewNop(), s.logger, metricsScope, false, isAdvancedVisEnabled) } else { params.MessagingClient = nil