Sarif output has wrong file path value for file scans

[devang-gaur]

Directory Scan

./bin/terrascan scan -d pkg/iac-providers/terraform/v14/testdata/relative-moduleconfigs/elasticcache/ -o sarif                                                                                                                                        
{
  "version": "2.1.0",
  "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",
  "runs": [
    {
      "tool": {
        "driver": {
          "name": "terrascan",
          "version": "1.7.0",
          "informationUri": "https://github.com/accurics/terrascan",
          "rules": [
            {
              "id": "AWS.ElastiCache.DataSecurity.High.0424",
              "name": "noMemcachedInElastiCache",
              "shortDescription": {
                "text": "ElastiCache for Memcached is not in use in AWS PCI DSS environments"
              },
              "properties": {
                "category": "Compliance Validation",
                "severity": "HIGH"
              }
            }
          ]
        }
      },
      "results": [
        {
          "ruleId": "AWS.ElastiCache.DataSecurity.High.0424",
          "level": "error",
          "message": {
            "text": "ElastiCache for Memcached is not in use in AWS PCI DSS environments"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "file:///Users/dev-gaur/go/src/github.com/accurics/terrascan/pkg/iac-providers/terraform/v14/testdata/relative-moduleconfigs/elasticcache/main.tf"
                },
                "region": {
                  "startLine": 1
                }
              },
              "logicalLocations": [
                {
                  "name": "noMemcachedInElastiCache",
                  "kind": "aws_elasticache_cluster"
                }
              ]
            }
          ]
        }
      ]
    }
  ]
}

Check the artifactLocation.url value. It works fine for Directory scans, but works a bit wrong for File scans. Check the example below.

File Scan

./bin/terrascan scan -f pkg/iac-providers/terraform/v14/testdata/relative-moduleconfigs/elasticcache/main.tf -o sarif                                                                                                                                 
{
  "version": "2.1.0",
  "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",
  "runs": [
    {
      "tool": {
        "driver": {
          "name": "terrascan",
          "version": "1.7.0",
          "informationUri": "https://github.com/accurics/terrascan",
          "rules": [
            {
              "id": "AWS.ElastiCache.DataSecurity.High.0424",
              "name": "noMemcachedInElastiCache",
              "shortDescription": {
                "text": "ElastiCache for Memcached is not in use in AWS PCI DSS environments"
              },
              "properties": {
                "category": "Compliance Validation",
                "severity": "HIGH"
              }
            }
          ]
        }
      },
      "results": [
        {
          "ruleId": "AWS.ElastiCache.DataSecurity.High.0424",
          "level": "error",
          "message": {
            "text": "ElastiCache for Memcached is not in use in AWS PCI DSS environments"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "file:///Users/dev-gaur/go/src/github.com/accurics/terrascan/pkg/iac-providers/terraform/v14/testdata/relative-moduleconfigs/elasticcache/main.tf/main.tf"
                },
                "region": {
                  "startLine": 1
                }
              },
              "logicalLocations": [
                {
                  "name": "noMemcachedInElastiCache",
                  "kind": "aws_elasticache_cluster"
                }
              ]
            }
          ]
        }
      ]
    }
  ]
}