ignore existing peers in DialPeersAsync #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2327 +/- ##
===========================================
- Coverage 61.02% 60.99% -0.03%
===========================================
Files 197 197
Lines 16296 16302 +6
===========================================
- Hits 9945 9944 -1
- Misses 5490 5495 +5
- Partials 861 863 +2
|
ValarDragon
reviewed
Sep 4, 2018
p2p/switch.go
Outdated
| if addr.Same(ourAddr) { | ||
|
|
||
| if addr.Same(ourAddr) || sw.HasPeerWithAddress(addr) { | ||
| sw.Logger.Debug("Ignore attempt to connect to an existing peer", "addr", addr) |
There was a problem hiding this comment.
Do we want a log message if you try to connect to yourself? If so, would that warrant its own message?
There was a problem hiding this comment.
Not a biggie since it's Debug
ValarDragon
approved these changes
Sep 4, 2018
[breaking] remove Switch#IsDialing
to be consistent with other usages of addrBook across Switch
melekes
force-pushed
the
2253-dial-peers
branch
from
ad93b8d
to
a00f0bf
Compare
|
Refactored code a little bit. PTAL |
ebuchman
reviewed
Sep 5, 2018
| if addr.Same(ourAddr) { | ||
| sw.Logger.Debug("Ignore attempt to connect to ourselves", "addr", addr, "ourAddr", ourAddr) | ||
| return | ||
| } else if sw.IsDialingOrExistingAddress(addr) { |
There was a problem hiding this comment.
This will help, but afaict it won't fix the issue in every case because dials can still be concurrent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2253