Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --cpu=x64_arm64_windows as a compilation target on Windows #45151

Closed
ianier opened this issue Nov 24, 2020 · 7 comments
Closed

Allow --cpu=x64_arm64_windows as a compilation target on Windows #45151

ianier opened this issue Nov 24, 2020 · 7 comments
Assignees
Labels
stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:build/install Build and install issues type:feature Feature requests

Comments

@ianier
Copy link

ianier commented Nov 24, 2020

Compilation of TensorFlow on Windows currently assumes x64 as a target CPU architecture. Searching .bzl files for "x64_windows" shows the many places in TF where this assumption is made.

In principle, though, nothing should prevent compiling TensorFlow to target ARM64 on Windows (--cpu=x64_arm64_windows, see the bazel doc).

This feature request is about adding support for '--cpu=x64_arm64_windows' to produce ARM64 binaries. The goal is to be able to use TF on Windows on ARM 64 bits.

@ianier ianier added the type:feature Feature requests label Nov 24, 2020
@ravikyram ravikyram added the type:build/install Build and install issues label Nov 24, 2020
@ravikyram ravikyram assigned ymodak and unassigned ravikyram Nov 24, 2020
@ymodak ymodak added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 25, 2020
@ymodak ymodak removed their assignment Nov 25, 2020
@mihaimaruseac
Copy link
Collaborator

Will happily review and approve a PR

@tensorflowbutler tensorflowbutler removed the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Dec 2, 2020
@ianier
Copy link
Author

ianier commented Dec 13, 2020

I would happily work on a PR, but unfortunately my knowledge of Bazel and TF build system is nearly zero. Passing --cpu=x64_arm64_windows causes the TF build system to download LLVM instead of using MSVC.
@mihaimaruseac : Can you hint where to start fixing/patching? The initial goal is to get the MSVC toolchain invoked, then I should be able to work on the required code changes.

@mihaimaruseac
Copy link
Collaborator

TF needs to download LLVM to build as it contains a lot of code that uses LLV libraries directly (MLIR)

@Venkat6871
Copy link
Contributor

Hi,

Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.

The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.

Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.

@Venkat6871 Venkat6871 added the stat:awaiting response Status - Awaiting response from author label Aug 20, 2024
@Venkat6871 Venkat6871 self-assigned this Aug 20, 2024
Copy link

This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Aug 28, 2024
Copy link

github-actions bot commented Sep 4, 2024

This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.

@github-actions github-actions bot closed this as completed Sep 4, 2024
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:build/install Build and install issues type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

6 participants