Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate dropping side effects field #4259

Open
tafsiri opened this issue Nov 18, 2020 · 0 comments · May be fixed by #7057
Open

Investigate dropping side effects field #4259

tafsiri opened this issue Nov 18, 2020 · 0 comments · May be fixed by #7057
Assignees
@mattsoulanille
Labels
comp:core P2 stat:awaiting tensorflower type:others

Comments

@tafsiri
Copy link
Contributor

tafsiri commented Nov 18, 2020

As a follow-up investigating #4248 revealed that as of October, webpack 5 does not require the sideEffects entry anymore.

  • Investigate how well it (and our other target bundlers do) without that field
  • Understand how webpack 5 adoption is going and whether we just want to target that for the custom bundle flow.

This template is for miscellaneous issues not covered by the other issue categories.

For questions on how to work with TensorFlow.js, or support for problems that are not verified bugs in TensorFlow.js, please go to StackOverflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsoulanille mattsoulanille

Labels
comp:core P2 stat:awaiting tensorflower type:others
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove 'sideEffects' field from package.jsons mattsoulanille/tfjs
5 participants
@pyu10055 @tafsiri @mattsoulanille @rthadur @gaikwadrahul8