Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Treasury (tax-rate, reward-weight) update target height should be next epoch start block #197

Closed
yun-yeo opened this issue Jul 5, 2019 · 0 comments · Fixed by #231
Assignees
Labels
bug Something isn't working must Mustfix for target release.

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Jul 5, 2019

Describe the bug
updateTaxPolicy and updateRewardPolicy are updating new tax-rate and reward-weight with current ctx. The ctx height is the last block of current epoch, but treasury should update next epoch's tax-rate and reward-weight at the last block of current epoch.

To Reproduce

  1. swap luna to terra
  2. current epoch(tax-rate and reward-weight) will be set at the last block of current epoch, not next epoch.

Context & versions
core-v0.2.x

(if applicable) suggested solution
In updateTaxPolicy and updateRewardPolicy, change ctx input of keeper setter to ctx with next epoch height.

@yun-yeo yun-yeo added bug Something isn't working must Mustfix for target release. labels Jul 5, 2019
@yun-yeo yun-yeo self-assigned this Jul 5, 2019
This was referenced Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working must Mustfix for target release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant