Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/fix-time-zone #187

Merged
merged 2 commits into from
Jun 22, 2019
Merged

Bugfix/fix-time-zone #187

merged 2 commits into from
Jun 22, 2019

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jun 22, 2019 •
edited
Loading

…C instance

** Summary of changes **

To remove difference in time calculation, change all time object to UTC time zone

** Report of required housekeeping **

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

======

** (FOR ADMIN) Before merging **

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from dokwon June 22, 2019 01:14
@yun-yeo yun-yeo added bug Something isn't working daemon daemon updates must Mustfix for target release. test Testing labels Jun 22, 2019
dokwon
dokwon approved these changes Jun 22, 2019
View reviewed changes
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokwon dokwon merged commit bdf0358 into develop Jun 22, 2019
@dokwon dokwon deleted the bugfix/fix-time-zone branch June 22, 2019 01:19
@yun-yeo yun-yeo mentioned this pull request Jun 22, 2019
Merged
8 tasks
gregnuj pushed a commit that referenced this pull request Mar 30, 2023
@fragwuerdig
fix issues with liveness test (#187)
b54f04d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokwon dokwon dokwon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working daemon daemon updates must Mustfix for target release. test Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yun-yeo @dokwon