Bugfix/treasury update target epoch #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanjukim
approved these changes
Jul 19, 2019
yun-yeo
pushed a commit
that referenced
this pull request
Sep 3, 2019
* add chain id check to update endblocker only for columbus-2 * move chain-id check to update module * change treasury endblocker upate target to next epoch
dokwon
pushed a commit
that referenced
this pull request
Dec 10, 2019
* add chain id check to update endblocker only for columbus-2 * move chain-id check to update module * add chain id check to update endblocker only for columbus-2 * move chain-id check to update module * add gitattributes to prevent linguist from checking vendor code and documentations * newline at the end of file * Feature/recover-old-hd-path (#193) * add chain id check to update endblocker only for columbus-2 * move chain-id check to update module * upgrade $terracli keys add to support old mnemonic support * add address selection when interactive mode is enabled * remove tmp keys folder * change log update * gitignore update * add old-hd-path option to give option for recover * change mock ledger to accept custom coin type from config * Bugfix/peek epoch seigniorage (#196) * change PeekEpochSeigniorage to compute seigniorage by subtracting previous issuance from current issuance * add clog * test code update * Bugfix/treasury update target epoch (#198) * add chain id check to update endblocker only for columbus-2 * move chain-id check to update module * change treasury endblocker upate target to next epoch * Updated CHANGELOG * Changed PR template * update docs hints * update wording on some hints * correct minor typo in swagger * Feature/ Minor goreleaser changes (#223) * set same go release version as tests * replace deprecated `archive` * update to cosmos-v0.37.0 * runsim update * distribute oracle rewards to ballot winner immediately after tallying * add goverance module and register treasury tax-rate & reward weight update gov proposal * apply constant product swap * fix discord link in readme (#229) * change replenish&update pools to update only terra pool and do constant product to compute luna pool * change swap to do not add min-spared to contant product spread * fix wrong terracli description * Remove LunaPool from the keeper because it can be retrieved from CP/TerraPool, where CP = BasePool*BasePool * Remove unnecessary internal swap when computing spread * * fix market & treasury genesis export import feature * clear all epoch dependent historical info when exporting for zero height * add genesis test to market & treasury module * append market query long description * Set new parameter 'PoolRecoveryPeriod'. Blockly replenish Terra&Luna Pool by the amount of delta/PoolRecoveryPerio * Fix oracle/denoms/actives example in swagger (#251) * change base pool can be configured by param change proposal not by luna issuance systematically * [Feature][oracle] Add whitelist and Update reward distribution mechanism (#250) * removes oracle module account from blacklist of bank module; enable send to oracle module * * append new param whitelist to filter oracle active target denoms * change RewardFraction to RewardDistributionPeriod which indicates (RewardPool * VotePeriod / RewardDistributionPeriod) will be distributed as a reward to the oracle ballot winners in every vote period * fix tally to correctly collect ballot losers * Update guide document for columbus-3 (#239) * Update guide document for columbus-3 * Update market specification doc * fix requested changes * Feature/remove oracle slashing (#253) * removes oracle module account from blacklist of bank module; enable send to oracle module * * append new param whitelist to filter oracle active target denoms * change RewardFraction to RewardDistributionPeriod which indicates (RewardPool * VotePeriod / RewardDistributionPeriod) will be distributed as a reward to the oracle ballot winners in every vote period * fix tally to correctly collect ballot losers * remove oracle slashing feature * fix oracle genesis export import feature & clear oracle prevote, vote, price when for-zero-height export * append genesis test * merge * [Feature] Update cosmos-sdk to v0.37.2 (#240) * update to cosmos-v0.37.1 * fix oracle genesis export import feature & clear oracle prevote, vote, price when for-zero-height export * append genesis test * update cosmos-sdk to v0.37.2 * Bump Tendermint version to v0.32.6 to address p2p panic errors. * Bump SDK version to v0.37.3 * merge * Feature/refactoring (#254) * append overall testcode & oracle replenish bug fix * update market module comments * wip * update oracle module comments and lcd * update treasury module comments * clear tax-rates and reward-weights when exporting for zero height * updates for goreport (#255) * fix all query response to be bonded with height (#261) * register supply/ModuleAccount to auth ModuleCdc (#258) * * Append a single end point to query all prevotes of a validator (#256) * Append a single end point to query all votes of a validator * Append a single end point to query all active luna prices * fix oracle invalid prevote hash error msg to print byte length not string length (#259) * remove oracle account address from send blacklist (#257) * shortened default oracle voteperiod to 30 seconds. Need to reflect in genfile at col-3 release. (#264) * Bump SDK version to v0.37.4 (#266) * delete tools-stamp (#262) * fix treasury comments (#267) * change treasury keeper to store only indicators for the each epoch (#269) * change treasury keeper to store only indicators for the epoch data * records tax-proceeds only for the tax-rate not whole tx.Fee * add keeper testcode * change stored indicators from TRL,SR,MR to TR,SR,TSL * swagger update * [Feature] oracle refactor & add oracle slashing (#265) * storing changes to tally, abvi, and keeper * Revert "storing changes to tally, abvi, and keeper" This reverts commit 70445a8. * stylistic refactor done - not building * Refactored oracle module. changing variable names Price references changed to ExhangeRate * Refactored rewards to be given out only for luna removed claimpool, as it is no longer being used * Implement oracle slashing * update client code for miss count querying * align comment & change DistributionPeriod to DistributionWindow & do swagger update * jail the validator after oracle slashing * * extract slashing from the keeper * reduce tally cost by computing vote power at organizing * split abstain vote for each denom * fix merge err (#271) * * change treasury init genesis to use current supply when epoch initial (#272) issuance is empty * update default params for oracle and market module * chore(ci): remove git cache related to job failure: https://app.circleci.com/jobs/github/terra-project/core/3048 * fix oracle rest path (#274) * bind height to rest query (#275) * skip oracle slashing for not passed ballot * [Bugfix] Add features to sync swagger doc (#283) * add features to sync swagger doc * ci test * align oracle parameters to units of blocks (#279) * [Bug] fix to apply reward spread by multiplication (#281) * fix to apply reward spread by multiplication * remove print * align params stringify (#286) * allow non-positive exchange-rate vote (#287) * create new event manager per tx (#290) * [Feature] oracle MsgDelegateFeedConsent.Deleagtee to Delegate (#288) * oracle MsgDelegateFeedConsent.Deleagtee to Delegate * increase oracle reward_band * change log update for columbus-3 release (#268) * prevent overflow by blocking huge input at handler & querier (#291) * go-releaser udpate (#299) * reward policy param update (#296) * create oracle account at init genesis (#293) * remove docs from the core repo (#298) * fix oracle endpoint to accept voter variable (#295) * [Feature] New market params for the high volatility TERRA (#300) * add market parameter TobinTaxList to specify a more strict tobin tax for the denom with high volatility * modify the param TobinTaxList to IlliquidTobinTaxList * typo * genesis update script for columbus-3 (wip) (#244) * genesis update script * modify min tax rate to 0.1% * param update for increased slahsing penalties * change address * param update * increase oracle slash_window to 1 month * increase reward band & update tax-cap * fix scriptg * update genesis update script * update max reward weight to 50% * genesis script final update * add illiquid_tobin_tax_list on market params * change circle ci for auto gorelease execution (#306) * build tx signatures as many as necessary for the msgs (#303) * fix banner & changelog version (#301) * swagger update (#305) * [Bugfix] genesis script (#304) * check if unbonding delegations exist * genesis script change illiquid_tobin_tax_list from object to list * recover vesting schedule changes * decrease oracle slashing fraction to 0.01%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
updateTaxPolicy and updateRewardPolicy are updating new tax-rate and reward-weight with current ctx. The ctx height is the last block of current epoch, but treasury should update next epoch's tax-rate and reward-weight at the last block of current epoch.
In updateTaxPolicy and updateRewardPolicy, change ctx input of keeper setter to ctx with next epoch height.
Related issue: #197
Report of required housekeeping
======
(FOR ADMIN) Before merging