Release v2.13.0 destroys ACM validation records

[nickelozz]

I'm creating this issue to raise awareness.

With the release of v2.13.0, performing a terraform apply will remove a duplicate route53 validation record (see more here).

However, as mentioned in this comment, removing the duplicate record from the state file will effectively remove the actual record from AWS even though there's still 1 entry in the state file.

The way I solved this situation was by removing the duplicate record from the module with something like the following before yielding the first terraform apply post-module upgrade:

terraform state rm module.acm.aws_route53_record.validation[1]

@antonbabenko perhaps a release note mentioning this situation could come in handy for people upgrading to this module version?

[antonbabenko]

Good point, terraform state rm aws_route53_record.validation[1] where [1] can be something else depending on your inputs. Could you open a PR that updated README about this?

[nickelozz]

Hi, @antonbabenko I can definitely do that. Do you have any preference on where to add this info? I'm thinking of putting it under Notes.

[antonbabenko]

Yes, Notes sounds reasonable.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.