Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Dont set -x in userdata to avoid printing sensitive informations in logs #1187

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

myoung34
Copy link
Contributor

PR o'clock

Description

Resolves #1186

Checklist

@myoung34 myoung34 changed the title Dont set -x in userdata fix: Dont set -x in userdata Jan 18, 2021
@myoung34
Copy link
Contributor Author

@antonbabenko Any hope for a review?

@antonbabenko
Copy link
Member

@myoung34 I am not so much involved in the development and release process of this particular module, so let's wait for @barryib who has been the leading force in this one for a rather long time.

@barryib barryib changed the title fix: Dont set -x in userdata improvement: Dont set -x in userdata to avoid printing sensitive informations in logs Jan 28, 2021
@barryib barryib merged commit 84a3761 into terraform-aws-modules:master Jan 28, 2021
@myoung34 myoung34 deleted the bash_set branch January 28, 2021 22:55
ArchiFleKs pushed a commit to ArchiFleKs/terraform-aws-eks that referenced this pull request Apr 16, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not set -x for bash userdata
5 participants